search

gregwinn / ystock

Yahoo market data, (realtime) stock data.
http://winn.ws
15 stars 3 forks source link

Remove HTTParty dependency and legacy Google API #6

Closed wakproductions closed 9 years ago

wakproductions commented 9 years ago

I had a depedency problem using this in my project because I'm using a newer version of HTTParty for other purposes. Bundler wouldn't let me install the gem because of the version incompatibility.

gregwinn commented 9 years ago

I will review the changes and update once finished.

gregwinn commented 9 years ago

I can approve this pull request pending one change (noted in your request file: spec/yahoo_spec.rb Lines: 11 & 12).

Thanks!

wakproductions commented 9 years ago

I updated the branch but it seems you removed the troublesome HTTParty dependency in 0.4.9. FYI, you may need to push out 0.4.9 to RubyGems.org... the line in my Gemfile not working for 0.4.9.

gem "ystock", "~> 0.4.9"

I would also recommending using tags in Git for versioning.

gregwinn commented 9 years ago 
gem "ystock", "~> 0.4.10"

Now live with this pull request.