gregzaal / Gaffer

A light-manager add-on for Blender
387 stars 30 forks source link

Installation problems with 2.81 and 2.82 #112

Closed andgeno closed 4 years ago

andgeno commented 4 years ago

Hi,

I tried this addon with 2.81 and 2.82 and had problems with both of them.

2.81 Blender says it installed the addon successfully but it does not show up in the installed list.

2.82 Blender says it installed the addon successfully. When I try to enable the addon it throws an error:

Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender 2.82\2.82\scripts\modules\addon_utils.py", line 351, in enable
    mod = __import__(module_name)
ModuleNotFoundError: No module named 'Gaffer-3'
gregzaal commented 4 years ago

It works for me in all versions of 2.8, including 2.83 Alpha from builder.blender.org.

Make sure it's installed to the correct location: C:\Users\you\AppData\Roaming\Blender Foundation\Blender\2.83\scripts\addons\Gaffer\__init__.py


Edit: hijacking this comment to explain the solution: You're downloading the ZIP from github, which names it according to the version number automatically. This cannot be installed directly inside blender, you need to either install the add-on manually by extracting it to the correct location yourself (see path above), or have a correctly configured ZIP file to begin with (as is distributed on the Blender Market).

Cornbrother commented 4 years ago

I can confirm this is still an issue but that it is because the Gaffer-3-1-4 folder within the zip is labeled Gaffer-3.1.4. and blender takes exception to this. If you rename the folder to Gaffer-3-1-4 within the archive and install it then it works without incidence.

gregzaal commented 4 years ago

Or just rename the folder to Gaffer as I already said. Github names the zip file according to the version, nothing I can do about that. The version I upload to the blender market is correctly named and works immediately.

andgeno commented 4 years ago

Obviously a build error of the release zip files. It shouldn't require users to rename the content of an installable addon zip file.

EDIT: Can confirm that renaming the folder (inside the zip!) fixes the issue.

ChildishGiant commented 2 years ago

I wonder if there's some way to make this show a custom error explaining the solution. I imagine not since the error is coming from blender itself. I know this could be fixed with GitHub actions or renaming the release items but I understand if you don't want to as this is a paid product. Legally talking you are allowed to not have the source publicly available, it just needs to be available to those who purchase the add-on IIRC.

deadman49 commented 2 years ago

No matter what i rename the folder to "Gaffer-3.1.9" or "Gaffer-3-1-9 or "Gaffer", it was still popup issuse. I'm using blender 3.0.