gregzaal / Texture-Haven

Website code for texturehaven.com
GNU Affero General Public License v3.0
15 stars 4 forks source link

Texture view does not show subcategory #6

Open JayFoxRox opened 4 years ago

JayFoxRox commented 4 years ago

This texture was found in "Concrete > Bare" using the navigation:

See https://texturehaven.com/tex/?c=concrete&t=concrete

The header in the texture view reads "Textures > Concrete" and the information below only reads "Categories: concrete". The "Bare" was dropped from the category list and the header.

gregzaal commented 4 years ago

"bare" is the tag, "concrete" is the category, and "concrete" is also the name. Not a very good name imo, but that's the name Rob chose for it :)

Tags (which just become search terms) are not stored for navigation, this could possibly be improved, but it's a low priority as people just can use their browser's back button instead of the navigation above the texture name.

JayFoxRox commented 4 years ago

Tags (which just become search terms) are not stored for navigation,

Oh, I never realized that subcategories are just search terms. When looking at the "&s=subcategory" I figured "s" stood for subcategory. Obviously that's not the case. It's the generic search (which can also lead to textures being shown in multiple subcategories).


I probably got confused by something like this: https://texturehaven.com/tex/?c=bricks&t=castle_brick_broken_06

This was found using "Bricks > Broken", however, it has:

Categories: bricks Tags: rough, seamless

Note the lack of the "broken" tag. Only now do I realize, that it was found because of it's name, not because of it's category or tags.

(Shouldn't it also be tagged "broken" then, for consistency?)


I guess we can close my issues about subcategories then, as there isn't an actual subcategory to begin with. I only thought this might be interesting for access via web-scraper or some API. But if this information isn't stored in the first place, it's not necessary. I doubt users of the website would care either.

For a proper implementation of subcategories, one could add custom categories for all subcategories.