search

gregziegan / elm-autocomplete

Autocomplete for Elm apps; in Elm
http://package.elm-lang.org/packages/thebritican/elm-autocomplete/latest
BSD 3-Clause "New" or "Revised" License
173 stars 43 forks source link

Hide menu on Esc, and onBlur. Actually hide it. #19

Closed maximsch2 closed 8 years ago

maximsch2 commented 8 years ago

Hopefully fixes #14 and #18

gregziegan commented 8 years ago

Thanks for this @maximsch2! Small but important fix. If you remove that complete = not bool, I'll go ahead and merge! (Or we can discuss further if my comment wasn't clear / you think I'm wrong)

maximsch2 commented 8 years ago

I agree that completed = not bool is probably a hack, but without it the menu never goes away, this is actually the most important part.

gregziegan commented 8 years ago

I figured out a solution by updating the update function, I'll make a PR after merging this one! It'll resolve the one issue with your PR that is:

When clicking on an item, the blur event fires for the input field, and the text is not filled in