search

gregziegan / elm-autocomplete

Autocomplete for Elm apps; in Elm
http://package.elm-lang.org/packages/thebritican/elm-autocomplete/latest
BSD 3-Clause "New" or "Revised" License
173 stars 43 forks source link

Integer IDs #35

Closed maximsch2 closed 8 years ago

maximsch2 commented 8 years ago

Current toId has to return a String. Is there any reason why that is the case instead of arbitrary comparable?

gregziegan commented 8 years ago

So that Html.Keyed has a String to identify nodes. I used Keyed.ul in elm-autocomplete so that node diff-ing is quicker.

I took inspiration from: http://package.elm-lang.org/packages/evancz/elm-sortable-table/1.0.0/Table#config

maximsch2 commented 8 years ago

Makes sense, thanks for explaining!