search

grehan-freebsd / grub2-bhyve

GNU General Public License v3.0
51 stars 21 forks source link

Build fails on 13-CURRENT - depends on removed gets(3) function #10

Closed woodsb02 closed 4 years ago

woodsb02 commented 4 years ago

emaste@ recently removed gets(3) from FreeBSD 13-CURRENT [1].

Now grub2-bhyve is failing to build [2].

[1] https://reviews.freebsd.org/rS351659 [2] https://www.mail-archive.com/freebsd-pkg-fallout@freebsd.org/msg1264597.html

grehan-freebsd commented 4 years ago

Just saw the msg about fgets() being a possible replacement so will look into that.

sarcasticadmin commented 4 years ago

I ran into this last weekend and raised this issue on the bugs.freebsd.org. See ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241168

sarcasticadmin commented 4 years ago

@woodsb02 just submitting a patch to the bugzilla issue

woodsb02 commented 4 years ago

Thanks! Peter - did you want to vet this patch before it gets committed?

grehan-freebsd commented 4 years ago

I had a look. grub2 doesn't use gets() at all so it's just an error in the glib header file as a result of gets being excised from FreeBSD. Commenting out the _GL_WARN_ON_USE macro for that is fine.

sarcasticadmin commented 4 years ago

Thanks for the quick feedback!

woodsb02 commented 4 years ago

Thanks for the patch Robert. I have committed it to the ports tree now, but note that I made the patch apply for all operating system versions, not just FreeBSD 13-CURRENT.

Peter - did you want to continue to carry the patch locally in the ports tree, or include it in this upstream repo and cut a new release?

grehan-freebsd commented 4 years ago

I'll eventually include it here but the ports patch will be fine for now.

grehan-freebsd commented 4 years ago

Committed; will create a new release so the port can pull from that.