search

greiman / SSD1306Ascii

Text only Arduino Library for SSD1306 OLED displays
MIT License
500 stars 122 forks source link

Add support for the vertically orientated SH1107 #105

Open jonathanmlang opened 1 year ago

jonathanmlang commented 1 year ago

Requires the fix in issue #104 to be applied.

greiman commented 1 year ago

None of your pull requests will be applied since I have a private beta. It may be a few months until I post mods I have made to the beta.

I have about a dozen displays and test all before new versions.

jonathanmlang commented 1 year ago

Thats fine, Just wanted to put it out there for you to decide what you wanted to do. Just thought this was the best way of suggesting these things. For now I wont be contributing any more to this library other than bug reports.

greiman commented 1 year ago

I probably should have a beta version of this library. It is amazing how often simple mods break apps for users.

Today I found that this fails on many "Arduino compatible board packages".

Serial.write("abcdefghijk", 5);

Arduino has this in Print.h:

    virtual size_t write(const uint8_t *buffer, size_t size);
    size_t write(const char *buffer, size_t size) {
      return write((const uint8_t *)buffer, size);
    }

Many board packages don't have the support for const char* so my entire SdFat library won't compile on these boards.

That's why I stopped applying what looks like simple mods.

It means a huge amount of testing for each release. I need to run many examples on many boards and displays.

jonathanmlang commented 1 year ago

Thats fair enough, ive been on the recieving end of that on many occasions when I download the latest version of other peoples libraries and find something really basic is broken due to a new feature rendering it useless. marlin firmware being one of the worst ive experienced off the top of my head.