search

greiman / SSD1306Ascii

Text only Arduino Library for SSD1306 OLED displays
MIT License
502 stars 122 forks source link

rest method #14

Closed eos1d3 closed 8 years ago

eos1d3 commented 8 years ago

This is a suggestion only.

Do you consider to move reset method out of SD1306Ascii.cpp.

This is hardware/mcu dependence. Once it is moved out, the whole cpp can be used by any other platform. I have ported it to STM8 already. The only change is the reset method (and a little to SPI class).

Without moving it out, you will need to include mcu header files inside. So I moved it out. Then the rest of the codes complied fine.

I moved it via a virtual to SPI class. So only SPI file has mcu dedicated headers while SD1306Ascii.cpp is so clean and works with any platform.

greiman commented 8 years ago

Currently I have little interest in developing this library for other than Arduino boards. I just don't have time for all the projects I am involved with.

In fact I am not using Arduino much for my personal projects. I mostly develop with Cortex-M boards and I like the ChibiOS/RT RTOS system.