search

greizgh / vaultwarden-debian

vaultwarden_rs packaging tool
GNU General Public License v3.0
55 stars 16 forks source link

feature: support ubuntu LTS #9

Closed bd4 closed 4 years ago

bd4 commented 4 years ago

Ubuntu LTS uses Glibc 2.27. The rust Docker images for Debian buster used as of 1.13.0 use Glibc 2.28, and the resulting binary does not work on LTS. I hacked the Dockerfile to use an ubuntu image as base and install rust using rustup, and was able to build a working glibc 2.27 binary. I can clean this up and submit a PR, if there is interest in including it? I am happy to maintain support for Ubuntu LTS going forward. Sort of wish I had made my server vanilla debian, but debian was in a big gap in stable releases and out of date at the time, and converting now would be a pain. I don't have the need to support other ubuntu release, but it should be easy if someone wants it.

greizgh commented 4 years ago

FYI, support for building the latest version on stretch has recently been introduced. You can build for stretch with:

./build.sh -o stretch

I think the resulting package can be successfully installed on Ubuntu LTS as it's built for glibc 2.24. Let me know.

If it does not install properly, then I guess we can extend the debian target selection mechanism to also offer support for other distributions.

bd4 commented 4 years ago

Thanks, I just tested this with the new bitwarden_rs 1.14 release using stretch target, and it installed fine on Ubuntu and appears to be working normally. I'm going to go ahead and close the issue.