grem11n / terraform-aws-vpc-peering

Terraform module to setup VPC peering connection
https://registry.terraform.io/modules/grem11n/vpc-peering/aws/latest
Apache License 2.0
126 stars 91 forks source link

fix Error: Duplicate provider configuration #31

Closed ozbillwang closed 3 years ago

ozbillwang commented 5 years ago

fix #30

ozbillwang commented 5 years ago

Not sure why Terratest is failed, it should be no impact for my changes.

grem11n commented 5 years ago

@ozbillwang, thank you for your contribution! I will check the Terratest this weekend.

ozbillwang commented 5 years ago

@MaxymVlasov

I have updated the PR, please review ifi it is suitable.

grem11n commented 5 years ago

@ozbillwang, I was unable to reproduce the bug mentioned in #31 Please, check my comment there: https://github.com/grem11n/terraform-aws-vpc-peering/issues/30#issuecomment-526181090

tyrken commented 5 years ago

Like the updated README.md, but we need to keep the provider alias declarations inside the module. They are needed when aliases are used.

grem11n commented 3 years ago

Closing due to inactivity