search

grem11n / terraform-aws-vpc-peering

Terraform module to setup VPC peering connection
https://registry.terraform.io/modules/grem11n/vpc-peering/aws/latest
Apache License 2.0
126 stars 91 forks source link

Allow newer aws provider versions #86

Closed saulius closed 2 years ago

saulius commented 2 years ago

Most terraform modules seem to use optimistic provider version constraint, would it work here too?

Solves https://github.com/grem11n/terraform-aws-vpc-peering/issues/85

wielkiborsuk commented 2 years ago

I successfully loosened this constraint and was able to validate/plan changes with aws provider 4.5.0

@grem11n Please merge this whenever possible :)

grem11n commented 2 years ago

Thank you for your contribution, @saulius ! And sorry for delay.

Tests are failing, but as far as I can tell, it’s not related to your change. I will try to fix the tests before releasing a tag, but in the meantime you can use the master branch version of this module. This is not recommended in general, but hopefully I will figure out the tests soon. I probably need to make a few enhancements as well e.g. use the latest version of Terraform for the tests, etc.

Cc: @wielkiborsuk

grem11n commented 2 years ago

@saulius , @wielkiborsuk , I've just released a new tag v.4.1.0 that incorporates this change: https://github.com/grem11n/terraform-aws-vpc-peering/releases/tag/v4.1.0 You can now pin it in your code!

Thank you for your contribution!

saulius commented 2 years ago

Many thanks @grem11n !