search

grenaud / gargammel

gargammel is an ancient DNA simulator
GNU General Public License v3.0
26 stars 15 forks source link

Make Python scripts compatible with Python 3 #8

Open marcelm opened 4 years ago

marcelm commented 4 years ago

Following up on the discussin about the Conda recipe at #7, I found that these commands are sufficient to make the ms2chromosomes.py script be compatible with Python 3:

sed -i.bak 's|\t|        |g' ms2chromosomes.py
2to3 -w -n ms2chromosomes.py

Since Python 2 has reached end of life, it would be nice if this were done here directly, so we don’t have to add the above to the recipe build script.

The msprime_chromosomes.py appears to already run on Python 3, so no changes were needed.

grenaud commented 4 years ago

Perfect! thank you for apprising me!

On Thu, May 7, 2020 at 11:03 AM Marcel Martin notifications@github.com wrote:

Following up on the discussin about the Conda recipe at #7 https://github.com/grenaud/gargammel/issues/7, I found that these commands are sufficient to make the ms2chromosomes.py script be compatible with Python 3:

sed -i.bak 's|\t| |g' ms2chromosomes.py

2to3 -w -n ms2chromosomes.py

Since Python 2 has reached end of life, it would be nice if this were done here directly, so we don’t have to add the above to the recipe build script.

The msprime_chromosomes.py appears to already run on Python 3, so no changes were needed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/grenaud/gargammel/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQRNIZCX4CXIV5ZKGJ7SM3RQJ2NVANCNFSM4M3EP5HQ .