grendizerufo / nvidia-texture-tools

Automatically exported from code.google.com/p/nvidia-texture-tools
Other
0 stars 0 forks source link

CG_INCLUDE_PATH instead of CG_INCLUDE_DIR #102

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to compile anything using convention CG_INCLUDE_DIR in your own
CMakeLists.txt
2. Fail

What is the expected output? What do you see instead?

You are breaking CMake convention for naming include dirs for packages.
Instead of naming them in LIBRARYNAME_INCLUDE_DIR fashion, you use
LIBRARYNAME_INCLUDE_PATH convention, which is totally unexpected...
I lost half an hour to find out why it all goes wrong :>

Original issue reported on code.google.com by kuba.sta...@gmail.com on 6 Oct 2009 at 6:06

GoogleCodeExporter commented 9 years ago
Hmm... the documentation is at the top of the file :)

Is there any documentation about the package convention? I believe I based this 
cmake
file on one from the original distribution, but that was long time ago, so
conventions might have changed, or maybe that was simply an error. I'd be happy 
to
change it, if that's indeed the case.

Original comment by cast...@gmail.com on 6 Oct 2009 at 6:41

GoogleCodeExporter commented 9 years ago
Now I know where to look and I can see it too. :)

Regarding convention - I assume it by using other packages (OpenGL, SFML, Qt 
for 
instance) and they're using _DIR convention. And I am pretty sure I saw 
somewhere a 
comment about this. But there are some examples of XX_INCLUDE_PATH also...

Hmm, may be obsolete, but still:
http://www.cmake.org/Wiki/CMake:How_To_Find_Installed_Software

"Every module will define the following variables: 
<name>_FOUND 
<name>_INCLUDE_DIR or <name>_INCLUDES 
<name>_LIBRARY or <name>_LIBRARIES
"

Original comment by kuba.sta...@gmail.com on 6 Oct 2009 at 6:59

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r1137.

Original comment by cast...@gmail.com on 22 Jul 2010 at 2:35