search

greplytix / Hamlbars

Sublime Text 3 Syntax highlighting for .hamlbars files which is a combination of both Haml and Handlebars
MIT License
2 stars 0 forks source link

Change string from yellow to green #31

Closed anthonykulis closed 9 years ago

anthonykulis commented 9 years ago

Match coffee script plugin colors

ghost commented 9 years ago

Changing string color is ultimately dependent on the theme one is using, but we will find out if there's a different, context-appropriate scope to apply to strings for a desired result.

@jjviscomi mentioned that he prefers the strings to be yellow -- again, it all seems relative to the theme one is using in Sublime Text 3. We will discuss this further.

anthonykulis commented 9 years ago

@jjviscomi I told them to match coffee script plugin colors. this gives us a common color palette that already looks well. we can discuss this and what else can be done in scrum.

jjviscomi commented 9 years ago

The syntax highlighter should not override theme colors, it should just identify the different parts of the syntax for the theme to color. It is the themes job to set the colors.

On Jan 22, 2015, at 9:29 AM, Anthony Kulis notifications@github.com wrote:

@jjviscomi https://github.com/jjviscomi I told them to match coffee script plugin colors. this gives us a common color palette that already looks well. we can discuss this and what else can be done in scrum.

— Reply to this email directly or view it on GitHub https://github.com/greplytix/Hamlbars/issues/31#issuecomment-71037756.

anthonykulis commented 9 years ago

Yes and the theme I use is the most important one. @reesington @picchietti - set the color palette according to the theme selected, which is mine. :/