search

grepplabs / kafka-proxy

Proxy connections to Kafka cluster. Connect through SOCKS Proxy, HTTP Proxy or to cluster running in Kubernetes.
Apache License 2.0
501 stars 87 forks source link

Add SASL SCRAM support #26

Closed worms closed 5 years ago

worms commented 5 years ago

I have tested both SCRAM-SHA-256 and SCRAM-SHA-512. However, SCRAM-SHA-512 requires an upstream change to the scram library. Therefore I have commented out the SHA-512 code.

everesio commented 5 years ago

Thank you for your contribution! I need some time to setup the test environment and perform the review.

everesio commented 5 years ago

Without deep dive into code (I will do it later), I successfully tested SCRAM-SHA-256.

Let's wait for your https://github.com/xdg-go/scram/pull/1 to be merged to have complete implementation with SCRAM-SHA-512. After that PR is merged, the library should be vendored.

worms commented 5 years ago

Sounds good. I haven't heard anything from them yet :( I will give them a few more days. If by Wednesday I don't hear from them I will come up with another solution that doesn't rely on their type.

worms commented 5 years ago

Looks like the xdg-go guys are not around. I will make the change not reliant on that upstreamed change and upload at some point this week