grepplabs / kafka-proxy

Proxy connections to Kafka cluster. Connect through SOCKS Proxy, HTTP Proxy or to cluster running in Kubernetes.
Apache License 2.0
501 stars 87 forks source link

Fix certificate validation #65

Closed radekg closed 4 years ago

radekg commented 4 years ago

Hi @everesio. I have made a mistake in the original PR for this feature where the flags for the client certificate subject validation were not consistent. This PR fixes the problem and also documents the usage.

It also addresses a problem where the fields not used for validation were not ignored. This is fixed and covered by tests. Additionally, this PR resolves the issue with field values being out of order, also with tests.

radekg commented 4 years ago

@everesio fixed, thank you