Fix getStringArray, in that method, when length was -1 it was returni…

grepplabs / kafka-proxy

Proxy connections to Kafka cluster. Connect through SOCKS Proxy, HTTP Proxy or to cluster running in Kubernetes.

Apache License 2.0

501 stars 87 forks source link

Closed p53 closed 4 years ago

p53 commented 4 years ago

…ng length of uint

when i was making metadata request for all topics, getting array was returning out of memory exception, because getting size of array in case it was null, returned instead of -1 number of size max uint32 4294967295
https://golang.org/ref/spec#Numeric_types int=uint intXX=signed int
as i check problem may araise also elsewhere e.g. getStringLength, getVarintStringLength, in fact -1 conditions there should be unreachable

everesio commented 4 years ago

Thank you for reporting I will check it

everesio commented 4 years ago

The function should cast to int32 and later to int. The first cast was missing