grepplabs / kafka-proxy

Proxy connections to Kafka cluster. Connect through SOCKS Proxy, HTTP Proxy or to cluster running in Kubernetes.
Apache License 2.0
501 stars 87 forks source link

Additional flags fur the ldap plugin #71

Closed db3f closed 4 years ago

db3f commented 4 years ago

Our new LDAP Repository does not have a readonly user. Read access is performed without doing a bind first. So a flag (--search-ldap) was needed to trigger a search of the user DN in LDAP without providing a --bind-dn flag. I also added a flag (--ldap-cacert) for providing a (chain of) certificate(s) to verify the LDAP server's identity.

There are additional changes: A Dockerfile for building an image including the LDAP plugin, and a small Makefile change allowing to set a different Docker Repo. These changes would make my life easier, but they are not really important to me.

Best regards,

Matthias

everesio commented 4 years ago

Thank you for contribution. I modified a little your PR i.e. renamed the new flag to ldap-ca-cert-file and added a new one ldap-insecure-skip-verify