search

grepplabs / kafka-proxy

Proxy connections to Kafka cluster. Connect through SOCKS Proxy, HTTP Proxy or to cluster running in Kubernetes.
Apache License 2.0
501 stars 87 forks source link

chore: fix docker tagging failing when branch contains slash #96

Closed smoya closed 3 years ago

smoya commented 3 years ago

Docker builds are failing if tags contain slash characters (/). Tag names are generated from the git branch name, so it is not that uncommon to see / on the latest (i.e. git-flow pattern: feat/xxx, fix/xxx...).

This PR applies a simple sed command that replaces all / by _ on the branch name value used for generating the Docker image tag name.

smoya commented 3 years ago

Btw, you also have some missing secrets I guess:

Missing Dockerhub secrets
everesio commented 3 years ago

thank you the fix