search

greptileai / ubicloud

Open, free, and portable cloud. Elastic compute, block storage (non replicated), virtual networking, managed Postgres, and IAM services in public beta.
https://ubicloud.com
GNU Affero General Public License v3.0
0 stars 0 forks source link

Retry downloading the boot image if it fails non-prod environment #6

Open soohoonc opened 2 months ago

soohoonc commented 2 months ago

Retry downloading the boot image if it fails non-prod environment The boot image download can fail due to various reasons, such as network. We don't want it to cause failure in our E2E tests. This commit adds a retry logic to the boot image download in the E2E tests. I didn't add the retry logic for production case, because we might want to have a deeper look before blindly retrying.

Clean up the temp file if image download fails If the image download fails, the temp file is left behind, which breaks the idempotency of the image download. This commit adds a cleanup step to remove the temp file if the download fails.

soohoonc commented 2 months ago

this is the reference pr: https://github.com/ubicloud/ubicloud/pull/1682