search

greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust
GNU General Public License v3.0
2.87k stars 474 forks source link

Equal numbers (eng.) can appear both with a decimal separator and w/o: 10 / 10.0 #1857

Closed dorsiflexion closed 1 year ago

dorsiflexion commented 1 year ago

Steps to reproduce: Use net block config (see below) and watch the net block for some time.

Expected behavior: 10 will always be shown as 10.

Actual Behavior: 10 is sometimes displayed as 10 and sometimes as 10.0.

Additional Info: It is not wrong per se but it is unexpected and weird to look at. It gets annoying if you "allocate" 3 characters for a number (i. e. width 3 and pad with spaces or .eng(w:3)) which is enough in every single case, as far as i observed, except for this one number – 10.0. If it happens and 10.0 is displayed, the entire bar left of it is moved one character to the left, which distracts a lot, because this movement is much more salient than just white numbers changing in one place.

The alternative right now is wasting one character for every number where this can happen which is not great either.

I guess it might has something to do with rounding: 10.0–10.49 is 10 and 9.995–9.9999999… is 10.0? Or maybe it's something else and 10.0 is just 10.0 and ≥10.1 is 10

Config (net block):

[[block]]
block = "net"
device = "enp5s0"
format = " ^icon_net_down $speed_down.eng(prefix:K, w:3) ^icon_net_up $speed_up.eng(prefix:K, w:3) "
interval = 5

Pics or it didn't happen: 10 10.0 Both numbers appear on both sides, I just don't have a screenshot of both on the same side…

MaxVerevkin commented 1 year ago

@dorsiflexion this should be fixed in #1858, can you test it?

dorsiflexion commented 1 year ago

I've now been testing it for maybe 3 hours and have not yet seen the bar move. If I see it move I know this bug just occured and I most likely wouldn't miss that – which means it seems fixed so far.

But l'd say let me test (i. e. use) for another day or two.

dorsiflexion commented 1 year ago

Yep, I haven't seen it again so far. Seems fixed to me. Thanks a lot!

dorsiflexion commented 7 months ago

I don't think this is globally fixed. I just saw 1000KB, when there's also 1.0MB. I was too slow to screenshot the first one, I'm 100% sure though. The config for that part is still the same as above: format = " ^icon_net_down $speed_down.eng(prefix:K, w:3) ^icon_net_up $speed_up.eng(prefix:K, w:3) "