search

greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust
GNU General Public License v3.0
2.85k stars 470 forks source link

Fixed vpn widget rendering #1876

Closed totikom closed 1 year ago

totikom commented 1 year ago

this fix the issue, mentioned in #1867. The bug was caused by the order, in which Widget::set_values and Widget::set_format methods were called.

By the way, semantics of Widget::set_values is very unintuitive: it sets new values for State::Format case and silently does nothing on other cases.

Should I create a PR, which will change this behavior to something more intuitive?

MaxVerevkin commented 1 year ago

I think I fixed this in 55e9334 by allowing .set_values() before .set_format(), can you verify please?

totikom commented 1 year ago

I think I fixed this in 55e9334 by allowing .set_values() before .set_format(), can you verify please?

Yep, I'll check it. If it fixes the issue, I'll change #1877 so it will not depend on my fix.