greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust
GNU General Public License v3.0
2.82k stars 472 forks source link

Add weather icons for night #1941

Closed bim9262 closed 10 months ago

bim9262 commented 10 months ago

Also split off Fog/Mist from Cloudy

One thing I did consider, but didn't do was to make the weather a progression:

So this:

weather_fog = "\ue313" # nf-weather-fog
weather_fog_night = "\ue346" # nf-weather-night_fog

becomes:

weather_fog = [
    "\ue313", # nf-weather-fog
     "\ue346", # nf-weather-night_fog
]

This would also mean that there's less clutter for fonts that don't differentiate between day and night:

weather_fog = "\uf0c2" # fa-cloud
weather_fog_night = "\uf0c2" # fa-cloud

becomes:

weather_fog = "\uf0c2" # fa-cloud

Let me know what you think about that :)

MaxVerevkin commented 10 months ago

This would also mean that there's less clutter for fonts that don't differentiate between day and night:

Let me know what you think about that :)

Sounds nice! The only problem I can imagine is that this would make the night variants unnameable using the current ^icon_ syntax, but this applies to all progressions and after seven months no one has complained (https://github.com/greshake/i3status-rust/pull/1720#issuecomment-1704334119), so...

bim9262 commented 10 months ago

I'm not sure why someone would want to... But if you only wanted to show the night version you could override the icon in the config

MaxVerevkin commented 10 months ago

I'm not sure why someone would want to... But if you only wanted to show the night version you could override the icon in the config

I meant if someone wanted to reference the night version from their custom block or in some other block, for some reason. But since this applies to all progressions I is not much of a concern.

Also one weird thing about using a progression to represent day/night variant is that the order is not that intuitive.

Anyway, feel free to choose the option you think is better.

bim9262 commented 10 months ago

Also one weird thing about using a progression to represent day/night variant is that the order is not that intuitive.

I think that's reason enough to leave it as is.