Simplify some error handling and make it more structured

greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust

GNU General Public License v3.0

2.82k stars 472 forks source link

Simplify some error handling and make it more structured #1946

Closed MaxVerevkin closed 9 months ago

MaxVerevkin commented 10 months ago

Remove kind and block fields from Error.
Removed block field is replaced by BlockError struct.
Represent formatting errors (such as "placeholder not found") as an enum with thiserror macro.
Merge ResultExt and OptionExt into ErrorContext.

MaxVerevkin commented 10 months ago

Notable things that where broken and still are:

Invalid block-specific configuration does not bring down the entire bar. But errors in the "common" config options (such as merge_with_next = 1 do). This is inconsistent. It might be okay to fail completely in both cases.
Invalid click-handler button (such as button = "not a valid button") does not result in any sort of error.

bim9262 commented 9 months ago

I think these changes look good. Let's create new issues for the things that you mentioned that are still broken (assuming there aren't already issues open)