MaxVerevkin
commented
6 months ago In case with hueshift and backlight, I agree that they do a very similar task (they are even merged in my bar!) but have different interfaces, which may be confusing. Maybe we can start by adding cycle to hueshift and deprecating click_temp?
However I'm not sure if it makes sense to factor this functionality out since it will be used only in two blocks.
Search the code for
toggleto see what I mean.
Yes! This is something that would be really nice to implement for all blocks in one place, somehow.
Motivation
My initial impulse for this is that I use both
backlightandhueshift, and it'd be nice for them to behave the same way, but they don't. I mean, on one, I left-click continually tocyclethrough a set of target values, and on the other I left-click tosetone value, and then right-click toresetto the default. I can never remember which is which, and it's a minor annoyance.Looking at the code to try to fix this, I find that there is a lot of copy-and-paste across blocks. Each block is responsible for handling its configuration options from scratch with no support for common patterns like
cycle, incr-/decrementing a value with the scroll wheel, toggling a format, etc. Search the code fortoggleto see what I mean.Related issues
1915 (create a common way to designate widget state based on a numeric value within a certain range)
Proposal
I propose to start small, focused on my original motivation, and refactor the
cyclefeature of backlight and theset/resetfeature of hueshift so they both work identically. The handlers for common settings could be insrc/settings.rs. If this is successful, then piece by piece other parts can be factored out as desired.