search

greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust
GNU General Public License v3.0
2.81k stars 472 forks source link

Nameserver information to network block #2058

Closed jkauerl closed 2 weeks ago

jkauerl commented 1 month ago

This PR is the first implementation to add more information to the network block.

The previous discussion was held in the following issue #2053. Specifically the first step of reading the nameservers saved in etc/resolv.conf.

It files that are modified are netlinks.rs and net.rs. With the former being the one that changes the most by creating a function to read the file, modify the Device struct and the last file by updating the documentation and adding the information to be displayed.

jkauerl commented 2 weeks ago

Should I squash the commits into a single one or it is fine the way it is?

MaxVerevkin commented 2 weeks ago

Should I squash the commits into a single one or it is fine the way it is?

I usually do "squash and merge", so no need to do it manually.