search

greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust
GNU General Public License v3.0
2.88k stars 474 forks source link

Update to Font Awesome 5 #598

Closed carloabelli closed 4 years ago

carloabelli commented 4 years ago

There was some discussion of this in #130, but that issue is closed and cluttered with workarounds. Additionally the pango issue that was causing a lot of the hexboxes has now been fixed. Here is a list of icons to change for Font Awesome 5 with possible alternatives:

Icons that have to be updated:

Icons that could be updated:

Icons that are emojis (were these ever included in font awesome?):

ammgws commented 4 years ago

What's the availability of Font Awesome 5 like on Ubuntu and the like? Ideally would like to avoid bug reports coming in from users of those distros where there isn't an easy installable package available.

carloabelli commented 4 years ago

@ammgws

Looks like it's version 5 on both Ubuntu and Debian: https://packages.ubuntu.com/eoan/fonts-font-awesome https://packages.debian.org/buster/fonts-font-awesome

Given that it was released in 2017, it should be pretty widely available.

ammgws commented 4 years ago

Ubuntu 18.04LTS seems to still be on the 4.7 version.

carloabelli commented 4 years ago

Okay so in that case it would probably be best to create a new icon set for font awesome 5. Any thoughts on the updated icons?

atheriel commented 4 years ago

New LTS for Ubuntu is out this week, so it's not unreasonable to be thinking of this change soon. Thanks for all of your work collecting together the changes!

ammgws commented 4 years ago

Any thoughts on the updated icons?

This is what I think

cpu: tachometer-alt (1. seems more CPU-like to me rather than the chip icon, 2. the chip icon is already used for memory (assuming we dont change it), 3. same as the icon used in FA4)

volume_muted: volume-mute

net_up: upload net_down: download (I hate the current icons as they show so small for me)

net_wired: network-wired (I think this is a pretty universal icon)

ping: exchange-alt

uptime: stopwatch

memory: keep the current icon

carloabelli commented 4 years ago

This is what I think

I agree with these.

memory: keep the current icon

Personally I prefer the memory icon, but consistency is not a bad thing and overriding icons in the config is simple.

I'll update my other pull request to include these changes.

carloabelli commented 4 years ago

@ammgws Sorry I was busy and just now saw this. Looks like there were two small bugs, so here's a PR with the fixes.