search

greshake / i3status-rust

Very resourcefriendly and feature-rich replacement for i3status, written in pure Rust
GNU General Public License v3.0
2.88k stars 475 forks source link

Investigate if can use serde_json to get ip address instead of sed #812

Closed ammgws closed 4 years ago

ammgws commented 4 years ago

Originally done in #513 but had to revert due to a bug in Debian Buster's ip implementation. However since then there has been a new release of Buster (10.5) so perhaps it has been fixed...

Ref: https://github.com/greshake/i3status-rust/pull/513#commitcomment-39226333

ammgws commented 4 years ago

@hlmtre Assuming you've upgraded to 10.5, do you still get the empty object at the start of the array as you mentioned in https://github.com/greshake/i3status-rust/pull/513#commitcomment-39226333?

hlmtre commented 4 years ago

@hlmtre Assuming you've upgraded to 10.5, do you still get the empty object at the start of the array as you mentioned in #513 (comment)?

Unfortunately, yes, this is still present; the ip tools version remains iproute2-ss190107. Again, fully updated Debian system (release 10.5). I would consider this actually a misbehavior in iptools, not in i3status-rs. But we do need to be aware of that.

hlmtre commented 4 years ago

I have submitted a simple workaround in a pull request.