search

gresrun / GHSidebarNav

A clone of the new Facebook iOS UI paradigm
Apache License 2.0
607 stars 136 forks source link

Search Scope not removing on didSelectRow #14

Closed jkevlin2 closed 11 years ago

jkevlin2 commented 11 years ago

If you include scope on the search bar and then populate the list, the scope bar will not go away on when you select menu items other than the first one.

I see now that your storyboard version behaves correctly, so I will go over that code to see what the differences are. BTW: great project

gresrun commented 11 years ago

Let me know what you find.

jkevlin2 commented 11 years ago

Greg, The storyboard app, looks like it is much more mature. So I think I will just use it to go by. I'm not a fan of storyboards, so I may go back and try to back port it, but for now I'm just going to look at the storyboard app. Storyboards are not very compatible with version control, so that is my bias against them.

I tried out using scope with [GHSidebarNav]-storyboard and it seemed to work.

If you need more info on the bug just let me know.

Thanks again. John

On 2/15/13 11:09 AM, Greg Haines wrote:

Let me know what you find.

— Reply to this email directly or view it on GitHub https://github.com/gresrun/GHSidebarNav/issues/14#issuecomment-13613629.

jkevlin2 commented 11 years ago

I do have a question. If you are using a remote server to get the data to populate the search list, should you do a http sync request or async? You have wrapped that section in a separate thread, so it seems that it should be sync. -john

gresrun commented 11 years ago

You can do either. I placed it on another queue so you could synchronously handle it but that doesn't prevent you from doing an async request, either way will work.