search

gresrun / GHSidebarNav

A clone of the new Facebook iOS UI paradigm
Apache License 2.0
607 stars 136 forks source link

Strange Navigation Bar behavior with transitionFromViewController #21

Closed derekstavis closed 11 years ago

derekstavis commented 11 years ago

In actual configuration it's barely perceptive, but the glitch is there. It's possible to reproduce this bug with more detail by adding an animation to self transitionFromViewController: on method setContentViewController of GHRevealViewController.m. Also, enabling slow animations on iOS Simulator will do it too.

derekstavis commented 11 years ago

I don't really know how this affects master branch, as I'm working on Storyboard one.

gresrun commented 11 years ago

What is the glitch that I should look for?

derekstavis commented 11 years ago

Look at this link: https://dl.dropbox.com/u/56336/bugs/GHSidebarNav%231.mov I just added a 2 seconds cross dissolve animation on transitionFromViewController

gresrun commented 11 years ago

Is the solution just to not add an animation? I'm confused what the issue is about.

derekstavis commented 11 years ago

I digged a lot in code trying to find what's causing the issue but wasn't able to fix it.

IMHO the capability of adding cross-dissolve animation adds value and beauty to the implementation. Just not adding the animation will not fix the issue, it will mitigate it. It will be hidden, but still there. And if you pay attention, even when there's no animation there's an annoying graphical glitch (:

gresrun commented 11 years ago

I think I see what you're talking about. Not sure how to fix it either. My guess is that it is related to Auto-Layout taking it's time to correctly size the view when it is added... :frowning: