gresrun / jesque

An implementation of Resque in Java.
http://gresrun.github.io/jesque
Apache License 2.0
628 stars 131 forks source link

Version 2.1.3 breaks API compatibility from 2.1.2 #157

Closed StFS closed 5 years ago

StFS commented 5 years ago

The following change adds an abstract method to the net.greghaines.jesque.client.Client class: https://github.com/gresrun/jesque/commit/52fb913df30e45a80cbac6584218a80fc4e91317

This breaks compilation in our project since we've subclassed the ResqueClient class.

I would argue that the version published after this change should at least be a minor version (2.1.2 -> 2.2.0), but not a patch version as was the case (2.1.2 -> 2.1.3).

gresrun commented 5 years ago

OK. Too late now. 🤷‍♂️