Closed jdyen closed 5 years ago
Merging #14 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 3 3
Lines 225 225
=======================================
Hits 208 208
Misses 17 17
Impacted Files | Coverage Δ | |
---|---|---|
R/iterate_matrix.R | 94.21% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0f19a4d...48112e2. Read the comment docs.
Yes, I think the suggested edit to description is best
Have added that change to the descrition,
And now wiht recreated Rd files and correct %*%
formatting.
Awesome, thanks. Let me know when you're ready for a review
Good for review now.
Yep, this looks great. Thanks!
Could you please bump the dev version number and the date up and I'll merge it.
Awesome, thank you!
Following discussion in #5, set up to avoid matrix transposition in matrix multiplications. This is in line with standard usage in biology (n_{t+1} = A n_t).
Have not updated docs to reflect this. One option is to add an eqn to the
@description
ofiterate_matrix
, e.g.,Alternatively, could add this information to
@param matrix
or in@details
.