greta-dev / greta

simple and scalable statistical modelling in R
https://greta-stats.org
Other
527 stars 63 forks source link

first draft of greta_sitrep() for loading greta and establishing if t… #476

Closed njtierney closed 2 years ago

njtierney commented 2 years ago

…he software is ready to use

See #441 for linked issue.

It currently looks something like this:

image

Although I'm not 100% sure why "loaded Tensorflow 1.14.0" appears in the middle of the text.

I'm not 100% if it should initialise Python, and I need to test out how it fails in specific situations and what sort of instructions appear. For example, it should be OK if users don't want to use a greta conda env.

To do that I'll need to write some mocking tests, I think?

@goldingn do you have any thoughts on how this is presented and if this is useful? Do you think that a separate, load_greta_deps() or similar function should be used to load and establish Python (instead of needing to run greta code to trigger that step)

goldingn commented 2 years ago

This looks helpful! I think the initialisation is good. And necessary to make sure everything works.

Should the version numbers for TF and TFP be reported when saying what is available, to reiterate the requuirement and what is checked?

njtierney commented 2 years ago

Ok great, I'll leave the initialisation in then.

Yup, agree! Having thinking about this a bit more this past week I think a few more helpers on what to do if each part isn't installed are there. So overall:

njtierney commented 2 years ago

This is what it currently looks like:

image

Note this also removes the errant "Loaded Tensorflow 1.14.0" message as well.

njtierney commented 2 years ago

reduced exclamation marks

image

njtierney commented 2 years ago

Added mocking tests for different versions of software and software availability