search

gretad711 / colmar

0 stars 0 forks source link

Layouts #2

Open tommygebru opened 5 years ago

tommygebru commented 5 years ago

You're layouts are looking top-notch Greta, nice work starting the mobile layout sooner, at 770px.This will implement a mobile layout that will work well for a tablet device with responsive design in mind, and stop the elements from collapsing at lesser viewport widths

Overall this project is a little more complex so take some time and work through each section one-at-a-time, as you work through your project. 👀

tommygebru commented 5 years ago

There are a few minor tweaks you can make to existing elements to clean up your layouts, this includes reviewing certain elements for their margins, paddings or width size that may affect adjacent elements for each page section

One thing that definitely makes it easier is to help create a visual aide and identify the box model for all the webpage elements. For example: *{border: solid 1px orangered ;} or if you prefer *{background: rgba(0,0,0,.1);}

I like to use the rgba values because it shows overlapping HTML really well 👏

gretad711 commented 5 years ago

Hi Tommy! Thank you so much for reviewing my project. The feedback you gave me is great and I am incorporating it into my project now. I'm trying to understand the note about cleaning up my layouts for each section. I used the border: solid 1px red method while working on the project. BTW, thanks for the rgba method. It does show overlapping really well. I really don't know what questions to ask to better understand this note because i'm truly lost. When you open the file on your computer, does something not line up? Is the sizing off? I really want to fix this part of my project so any specific details will help. Thank you again!

tommygebru commented 5 years ago

This is general advice I like to give, to help students with minor tweaks to either their layout or the box model of certain elements 😁😁

gretad711 commented 5 years ago

Got it. That was great advice. I will be using that method moving forward. Thanks!

From: tommy notifications@github.com Sent: Thursday, May 23, 2019 12:23 AM To: gretad711/colmar Cc: gretad711; Comment Subject: Re: [gretad711/colmar] Layouts (#2)

This is general advice I like to give, to help students with minor tweaks to either their layout or the box model of certain elements 😁😁

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgretad711%2Fcolmar%2Fissues%2F2%3Femail_source%3Dnotifications%26email_token%3DALJ6ZYYLP4VVNDRCSRVKQQTPWXPXFA5CNFSM4HOVG4N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAW5OY%23issuecomment-495021755&data=02%7C01%7C%7Cc0dd86bc5dec43f4141108d6df14d8f1%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636941677956859064&sdata=45qwEp6ngiJztz42jcwq039QE6liVkK%2BQFtPiQ%2BYlD0%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALJ6ZY6RU6RHCMPQ23GPVXTPWXPXFANCNFSM4HOVG4NQ&data=02%7C01%7C%7Cc0dd86bc5dec43f4141108d6df14d8f1%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636941677956869069&sdata=IXmDwJwRE80UZt1p27jsKLyKzAscFDkhsRXMSiFeqUY%3D&reserved=0.