search

gretty-gradle-plugin / gretty

Advanced gradle plugin for running web-apps on jetty and tomcat.
MIT License
129 stars 36 forks source link

Isolate Classpaths of CLI Runner and Servlet Container #280

Closed boris-petrov closed 1 year ago

boris-petrov commented 1 year ago

Port of https://github.com/gretty-gradle-plugin/gretty/pull/270 to master.

cc @f4lco

boris-petrov commented 1 year ago

I'm not sure whether we have to incorporate https://github.com/gretty-gradle-plugin/gretty/pull/268/commits/a167e9c2b54a28a5d9082ca1dbf965bbec8d0e1c here. @f4lco you're more familiar with that code and you can say if that code should stay (as I've done) - i.e. not add this commit - or whether the commit should be added too.

f4lco commented 1 year ago

I'm not sure whether we have to incorporate a167e9c here. @f4lco you're more familiar with that code and you can say if that code should stay (as I've done) - i.e. not add this commit - or whether the commit should be added too.

I think it's correct as-is, and if we added the commit, the built was bound to fail. You did good 👍

boris-petrov commented 1 year ago

The herculean effort was yours in the beginning, it was much easier now to just take the commits and just resolve the conflicts. :) I believe the only issue was with Logback - I had to update the version to 1.4.x for the build to pass.

Anyway, thanks, merging! :)