search

gretty-gradle-plugin / gretty

Advanced gradle plugin for running web-apps on jetty and tomcat.
MIT License
129 stars 36 forks source link

Remove usage of soon to be deprecated `Task.getProject` #313

Open abstratt opened 3 weeks ago

abstratt commented 3 weeks ago

Please avoid using Task.project at execution time as in here:

https://github.com/gretty-gradle-plugin/gretty/blob/5b99776fe8f4f7c53cac6aef63950b9e5e345e6d/libs/gretty/src/main/groovy/org/akhikhl/gretty/StartBaseTask.groovy#L60C45-L60C52 (and further places in the task action)

as it is going to be deprecated in Gradle 8.12, and forbidden in a future Gradle release.

Please see https://github.com/gradle/gradle/issues/30860

boris-petrov commented 3 weeks ago

@abstratt is this a new deprecation? Isn't this the same as #288 or it's something new?

abstratt commented 3 weeks ago

It is the same, or sort of. Before Gradle 8.12, you would only see that deprecation if enabling STABLE_CONFIGURATION_CACHE feature flag. From 8.12, users should see it regardless of that feature flag. Feel free to close as a duplicate, just beware it will be issued for all users, not only those enabling the feature flag.

boris-petrov commented 3 weeks ago

Ah, I see. Thanks for pointing that out. In any case, PRs are welcome for all deprecations!