greut / eclint

Mirror of
https://gitlab.com/greut/eclint
MIT License
13 stars 2 forks source link

Warn on any kind of BOM #6

Open szepeviktor opened 1 year ago

szepeviktor commented 1 year ago

I've created a file with Windows Notepad. It has UTF-8 BOM and CRLF line ends.

00000000  ef bb bf 61 6c 6d 61 20  42 4f 4d 0d 0a           |...alma BOM..|
0000000d

@greut How should I configure eclint to warn me that there is BOM in this file? Thank you!

greut commented 1 year ago

charset=utf-8 bom will warn you if the BOM is missing, however charset=utf-8 will accept any file with or without BOM it seems. Hence, it won't warn you as is.

I've added a tests there: https://gitlab.com/greut/eclint/-/merge_requests/145

which needs to be fixed at some point.

szepeviktor commented 1 year ago

Thank you.

greut commented 1 year ago

2c8c3ec817c99c06726ece10c0aad85cc094f4ae it needs a new release though.

szepeviktor commented 1 year ago

I am all in for new releases.

Thank you again.