search

greven / oUF_Lumen

World of Warcraft Addon : oUF Layout
Other
13 stars 7 forks source link

SpellWatchers: please don't use localized spec name as index #17

Closed kghost closed 4 years ago

kghost commented 4 years ago

For example in Druid.lua

watchers.DRUID = {
  Balance = {
    [1] = {spellID = 190984, auraID = 48517, glow = {type = "button"}}, -- Wrath / Eclipse
    [2] = {spellID = 194153, auraID = 48518, glow = {type = "button"}}, -- Starfire / Eclipse
    [3] = {spellID = 78674, glow = {type = "pixel"}}, -- Starsurge
    [4] = {spellID = 191034, glow = {type = "pixel"}}, -- Starfall
    [5] = {spellID = 78675} -- Solar Beam
  },
  Feral = {},
  Guardian = {},
  Restoration = {}
}

Because spec names are different in clients with different languages, this probably doesn't work in non-English clients. please change it into:

watchers.DRUID = {
  [102] = { -- Balance
    [1] = {spellID = 190984, auraID = 48517, glow = {type = "button"}}, -- Wrath / Eclipse
    [2] = {spellID = 194153, auraID = 48518, glow = {type = "button"}}, -- Starfire / Eclipse
    [3] = {spellID = 78674, glow = {type = "pixel"}}, -- Starsurge
    [4] = {spellID = 191034, glow = {type = "pixel"}}, -- Starfall
    [5] = {spellID = 78675} -- Solar Beam
  },
  [103] = {}, -- Feral
  [104] = {}, -- Guardian 
  [105] = {} -- Restoration 
}
kghost commented 4 years ago

Here is the table for specialization ID https://wow.gamepedia.com/SpecializationID

greven commented 4 years ago

Oh... I didn't know Spec names were localized too. Thanks for this, I will change it. Right now still closing development on this but I will change it before releasing to master. 👍