search

grevory / bootstrap-file-input

Standardizes the file input field to look like a Bootstrap button in all browsers
Other
179 stars 63 forks source link

[enhancement] Add missing bower.json. #24

Open timgluz opened 10 years ago

timgluz commented 10 years ago

Hey, maintainer(s) of grevory/bootstrap-file-input!

We at VersionEye are working hard to keep up the quality of the bower's registry.

We just finished our initial analysis of the quality of the Bower.io registry:

7530 - registered packages, 224 of them doesnt exists anymore;

We analysed 7306 existing packages and 1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).

Sadly, your library grevory/bootstrap-file-input is one of them.

Can you spare 15 minutes to help us to make Bower better?

Just add a new file bower.json and change attributes.

{
  "name": "grevory/bootstrap-file-input",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.

NB! Please validate your bower.json with jsonlint before commiting your updates.

Thank you!

Timo, twitter: @versioneye email: timo@versioneye.com VersionEye - no more legacy software!

grevory commented 10 years ago

Sorry for the delay. How is this? https://github.com/grevory/bootstrap-file-input/blob/master/bower.json

tkhduracell commented 10 years ago 
Post-install message from rails-assets-bootstrap-file-input:
This component doesn't define main assets in bower.json.
Please open new pull request in component's repository:
https://github.com/grevory/bootstrap-file-input

According to rails-assert there is main assets missing. But there is a main so I'm confused.

I think you can remove the ./ btw.

cavarzan commented 10 years ago

@grevory I don't know if this is the correct issue, but the tag v1.0.0 seems to not have the bower.json. This may cause the following issue when build some project using the lib because grunt didn't know the current path of the .js file:

bootstrap-file-input was not injected in your file.