search

grey-software / org

The organization repository for Grey Software, where software maintainers mentor students and build free software together!
https://org.grey.software
11 stars 0 forks source link

Research a possible pre-commit quality check for pull requests #36

Closed ArsalaBangash closed 4 years ago

ArsalaBangash commented 4 years ago

Research automated and manual checklists to ensure commits are of a certain quality.

AaronCGoidel commented 4 years ago

In the past, I’ve used Husky for pre-commit hooks. I’d recommend checking that out.

ArsalaBangash commented 4 years ago

@AaronCGoidel Do you have the bandwidth to configure Husky on Grey Software's repos?

AaronCGoidel commented 4 years ago

Sure, doesn't seem like too bad an undertaking. What hooks would we like set up?

I'm not aware of any test harness that we are using. I also think that we should decide on linting before we go ahead with setting up hooks.

ArsalaBangash commented 4 years ago

Formatting: Prettier Linting: ESLint Scripts: npm run build or npm run test if either exists. For most of our web projects, The build command exists