search

greyaz / ThemeRevision

A task-first and high-quality theme for Kanboard. It's also aimed at better mobile experiences, common plugin compatibilities, and customization friendly.
MIT License
51 stars 9 forks source link

Theme appears broken in kanboard v1.2.30 (latest release) #23

Closed dangerstudios closed 4 weeks ago

dangerstudios commented 1 year ago

This theme breaks the UI in the latest kanboard release: https://github.com/kanboard/kanboard/releases/tag/v1.2.30

image image

trebor2109 commented 1 year ago

The problem exists since Kanboard V1.2.29 when the new theme support (dark, light, automatic) was added. So the last working version of Kanboard for this theme here is version 1.2.28. It would be very cool if the theme here is adapted accordingly, that it also works under the current version (1.2.30). Thanks for the work on this theme.

xyttyxy commented 1 year ago

In 1.2.28 the visuals work but I cannot create new columns, swimlanes or rename existing ones. Clicking the save button has no effect.

Edit: just checked on KB 1.2.27 the above 2 points are working

pittss commented 1 year ago

Quick fix:

In file: /plugins/ThemeRevision/Template/layout.php Replace line 17

<?= $this->asset->css('assets/css/app.min.css') ?>

To

<?php if (! isset($not_editable)): ?>
    <?= $this->asset->css('assets/css/'.$this->user->getTheme().'.min.css') ?>
<?php else: ?>
    <?= $this->asset->css('assets/css/light.min.css') ?>
<?php endif ?>
mikhailnov commented 1 month ago

+1 for this

DangerDrome commented 4 weeks ago

@greyaz was this updated in the code reop or do we have to apply the quickfix mentione above?