search

greybaron / sap-notes-automation

0 stars 1 forks source link

changing accepted week values #3

Open jonasgeist123 opened 1 year ago

jonasgeist123 commented 1 year ago

here you go

jonasgeist123 commented 1 year ago

MERGE NOW 😡😡😡😡😡😡

greybaron commented 1 year ago

I don’t see the necessity for xlsx_new_new_target_path (from line 310 onwards). That variable only stored the 'target' filename and directory, in german format. Adding a fallback (?) in english format seems utterly pointless.

Of course, I'd also suggest that whoever was the genius who thought it was a good idea to read things ONE FCKING BYTE AT A TIME with system calls for each byte should be retroactively aborted. Who the fck does idiotic things like that?

greybaron commented 1 year ago

cant-reproduce, wont-fix, touch grass, issue closed

jonasgeist123 commented 1 year ago

hakan,

guck mal in deine MAILS :( 🤔. Die Inder senden das jetzt immer in der form xlsx_new_new_target_path und die datei umzubennen ist AÜSSERST NERVIG

On Wed, Feb 8, 2023 at 1:53 PM greybaron @.***> wrote:

I don’t see the necessity for xlsx_new_new_target_path (from line 310 onwards). That variable only stored the 'target' filename and directory, in german format. Adding a fallback (?) in english format seems utterly pointless.

Of course, I'd also suggest that whoever was the genius who thought it was a good idea to read things ONE FCKING BYTE AT A TIME with system calls for each byte should be retroactively aborted. Who the fck does idiotic things like that?

— Reply to this email directly, view it on GitHub https://github.com/greybaron/sap-notes-automation/pull/3#issuecomment-1422549422, or unsubscribe https://github.com/notifications/unsubscribe-auth/A25LKUKE3ONKFNGLSL7YHNTWWOJODANCNFSM6AAAAAAUUQ6AO4 . You are receiving this because you authored the thread.Message ID: @.***>