search

greybax / cordova-plugin-native-spinner

:arrows_counterclockwise: Cordova plugin for showing a native spinner based on Paldom/SpinnerDialog
MIT License
32 stars 19 forks source link

Please provide screenshots #12

Closed guylando closed 4 years ago

guylando commented 5 years ago

To decide if we want to use this plugin we must see screenshots of how it looks on android+ios.

andreszs commented 5 years ago

Posting screenshots would be misleading, as Google keeps changing the native spinner in every single Android version (maybe not so often in iOS), so whatever screenshot is uploaded it will correspond to a single Android version only. To see how it works, perform any operation that shows the system's spinner, like searching for mobile networks. That's the spinner and dialog you'll get.

guylando commented 5 years ago

I personally believe that it would help more people choose the library to see at least one image of each platform and can add a note that the image might be outdated depending on the OS. I mean images relevant for some devices are better than no images at all, in getting the general impression for a person not familiar with this. Think of this from marketing perspective, when did you see a product without any preview or demo or basic image?

guylando commented 5 years ago

Here is an example of what I speak about which greatly helped me understand that plugin even if the images are outdated and dont represent all the devices in the world: https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller#2-screenshots

narayanncube commented 5 years ago

Doesn't work on android or iOS over inappbrowser. Please help

andreszs commented 5 years ago

@narayanncube no Cordova events or methods are directly available from the InAppBrowser context.

To send an event from within your InAppBrowser to your Cordova app, you must use the message event from the IAB v3.1.0-dev. Check out the section Using the message event and postMessage API to close the InAppBrowser in that article, and modify it to show the native spinner instead of closing the IAB.

08Thug commented 4 years ago

can we change the color of the spinner!? If possible could anyone help me with it...

greybax commented 4 years ago

@08Thug on the first, spam is not good, isn't it? This question is about screenshots and not about spinner color. At second, you can see the code and read README.md the file that this plugin has limited support for the color spinner. You can change only spinner text color and only in iOS. So solution could be is to implement this functionality by yourself and maybe send PR to this repo.