search

greybax / cordova-plugin-proguard

:white_square_button: Cordova Plugin for ProGuard
MIT License
51 stars 265 forks source link

Correcting path for "proguard-android.txt" file in latest Android Cordova #5

Closed SujitSingh closed 5 years ago

SujitSingh commented 6 years ago

Correcting the path for proguard-android.txt in build.gradle file. I have tested out latest changes from forked repo. App works perfectly and the classes.dex file contains renamed class files.

closes #2

greybax commented 6 years ago

@SujitSingh thank you for PR! Do you know will this change works with Cordova version <7 ?

SujitSingh commented 6 years ago

Most probably, it won't because in older Cordova versions, file path is different than the latest one.

I haven't tested though in older Cordova versions.

greybax commented 6 years ago

We need to make it works for all Cordova versions

harshzalavadiya commented 6 years ago

Hi @greybax,

as cordova 7+ is having breaking changes in android platform. this plugin can have major version bump so other users can install older version of plugin if they don't want to use latest cordova because this will make plugin not usable with newer version of cordova.

So, it will be really great if PR can be merged with master so new application can use same plugin instead of using forked ones.

greybax commented 5 years ago

seems that cordova 7 version is super stable now and already we have cordova 8+. So I'll merge this PR into master branch and will bump new npm version.