search

greyblake / whatlang-rs

Natural language detection library for Rust. Try demo online: https://whatlang.org/
https://whatlang.org/
MIT License
966 stars 108 forks source link

Ruby codegen #37

Closed elegaanz closed 5 years ago

elegaanz commented 5 years ago

This is an alternative for #34 that generates the languages list with the Ruby helper in misc. It just needs to be run after a language is added to the list, as before. It removes the needs for almost all build dependencies, since all CSV and JSON parsing are now done in Ruby.

greyblake commented 5 years ago

@BaptisteGelez Thanks for the PR. I'll take a look this week

greyblake commented 5 years ago

@BaptisteGelez I am really sorry. Still didn't not have time to dedicate to your PR. Just to let you know, that I keep it in mind.

greyblake commented 5 years ago

@BaptisteGelez Thanks for the PR! I'll merge it. The tests fail because there meanwhile a new language was added (Afrikaans), but it is easy to fix by regenerating lang.rs.

elegaanz commented 5 years ago

Thank you for merging this! :blush:

greyblake commented 5 years ago

@BaptisteGelez thank you :)

Btw, I have released a new version v0.7.0 that has much fewer building dependencies now.