search

greyblake / whatlang-rs

Natural language detection library for Rust. Try demo online: https://whatlang.org/
https://whatlang.org/
MIT License
966 stars 108 forks source link

Too many public things #4

Closed Dr-Emann closed 7 years ago

Dr-Emann commented 7 years ago

I'm not sure it makes sense for things like whatlang::ARABIC_LANGS to be public, or get_trigrams_with_positions(..)

greyblake commented 7 years ago

Yea, definitely these things shouldn't be public. I kept this in mind. I will rearrange file structure a little bit later. As far as I've noticed, in solid Rust libraries, nobody keeps implementations in lib.rs file, it's used only to import/export functionality.

greyblake commented 7 years ago

Fixed in version 0.3.0 (see doc: https://docs.rs/whatlang/0.3.1/whatlang/)