greyblake / whatlang-rs

Natural language detection library for Rust. Try demo online: https://whatlang.org/
https://whatlang.org/
MIT License
966 stars 108 forks source link

Fix Arabic Iso Code from ara to arb #57

Closed godofdream closed 3 years ago

greyblake commented 3 years ago

@godofdream Thanks for the PR. I think the PR name opposite from what you intended to do.

I mean, you wanted to replace Arb with Ara, right?

I tried to investigate the topic. It looks like both ara valid ISO codes, however the scope is different.

https://iso639-3.sil.org/code_tables/639/data/a?page=1

image

I also ask my Egyptian friend regarding Arb VS Ara, he says:

I have never seen this "arb" word befire. I always notice "ara" in some websites

So generally I'm OK to accept the change if you confirm your intention to replace arb with ara. Thanks

greyblake commented 3 years ago

Thanks. The change is available in v0.11.0.