greymass / anchor

EOSIO Desktop Wallet and Authenticator
https://greymass.com/anchor/
MIT License
569 stars 221 forks source link

Nested Keys #1325

Open Vyryn opened 1 year ago

Vyryn commented 1 year ago

Description

Related to #1183

Ledger keys can not sign anything that uses an "account@permission" permission instead of a direct key permission. Issue #1183 says this is due to Ledger API not providing enough info. However, I accidentally stumbled on something that may make a potential workaround easy to implement.

Steps:

This seems to indicate that altering the signing account, as long as it is a valid signer for the requested account, is completely transparent to applications and to Ledger. Thus a possible workaround for 1183 is, on the "Identity Request" page, add an option to allow users to manually edit the "Prove Identity" field to the desired top level permission without editing the "Select an account" field, which can be unchanged from present. I've made a rough mock up below of what this might look like to the user:

image

Platform

Desktop (MacOS)

Steps To Reproduce

Steps:

Relevant log output

No response

Contact Details

No response

Anything else?

A workaround like this would be greatly appreciated, in that it would allow most of the range of robust permission management EOSIO offers to be used by Ledger users.

aaroncox commented 1 year ago

Hey - thanks for the report here. I haven't had a chance yet to reproduce the issue and check it out, but it's on my radar to check out. I'll leave this here until we get a chance to dive in and take a look at this.