search

greymatter-io / gm-ui-components

A library of reusable Grey Matter UI components.
MIT License
15 stars 6 forks source link

chore: vertically flip ekg icons #628

Closed tilleryd closed 2 years ago

tilleryd commented 3 years ago

Per this Slack conversation https://deciphernow.slack.com/archives/C4MKMC2EP/p1625779128201500

danielpcox commented 3 years ago

Not my area, but I wonder if we want to flip the strike-through like that for the "no" version of the icon? I'm used to "no" being a line from the upper-right to the lower left through the whatever we're saying "no" to.

tilleryd commented 3 years ago

Not my area, but I wonder if we want to flip the strike-through like that for the "no" version of the icon? I'm used to "no" being a line from the upper-right to the lower left through the whatever we're saying "no" to.

Ahh, this one will require the skills of @shanberg.

shanberg commented 3 years ago

The obvious default direction varies per glyph. There's a prop on the icon component to flip the negation direction per usage, because I didn't think of a nice way to inherit it from the glyph.

There may also be cases where you want the negation direction consistent across a set of icons, and not exclusively defined by the glyph itself.