greymd / tmux-xpanes

Awesome tmux-based terminal divider
MIT License
1.96k stars 61 forks source link

Optimize xpns_log_filenames & xpns_arr2args functions #182

Closed ReDTerraN closed 1 year ago

ReDTerraN commented 1 year ago

In this patch we optimize xpns_log_filenames to not spawn another sed process while being ran. also optimizing xpns_arr2args using a more more efficient syntax for iterating over the array, this is done by using _arg in "$@" directly instead of declaring _arg="${i}" every loop. As well as optimizing sed usage.

I have done some preliminary testing making sure that its working as expected, but I have not compiled and ran it. Please have a look before merging

Thanks for a great tool, cheers.

ReDTerraN commented 1 year ago

to clarify, with preliminary testing I mean checking that the sed works and that smoke screen tests went green.

greymd commented 1 year ago

looks good. thanks!